[cmake] On a fresh configure, remove possibly outdated pcms.#22751
Draft
hageboeck wants to merge 1 commit into
Draft
[cmake] On a fresh configure, remove possibly outdated pcms.#22751hageboeck wants to merge 1 commit into
hageboeck wants to merge 1 commit into
Conversation
When CMake is run without an existing cache, or with cmake --fresh, remove leftover pcms in lib/. This can fix a build with broken pcms that don't get regenerated without needing to clean the entire build.
Test Results 21 files 21 suites 3d 3h 3m 33s ⏱️ For more details on these failures, see this check. Results for commit 8ae89a0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CMake is run without an existing cache, or with
cmake --fresh, remove leftover pcms inlib/. This can fix a build with broken pcms that don't get regenerated without needing to clean the entire build.More details
The underlying problem is the fact that rootcling_stage1 builds some pcms as side effects (e.g. std.pcm), and CMake doesn't know about these. It therefore can't know if they are out of date, and it can't instruct the build-system generator to clean them when the clean target is invoked, or update them if they are out of date.
Although wiping the pcms only cures the symptoms, it could make the life of the developer a bit better until all pcms are correctly tracked by CMake.